Skip to content

fix(parse): type x = typeof import('') -> TSTypeQuery(TSImportType)#10317

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-09-fix_ast_type_x_typeof_import_should_be_tstypequery_tsimporttype_
Apr 9, 2025
Merged

fix(parse): type x = typeof import('') -> TSTypeQuery(TSImportType)#10317
graphite-app[bot] merged 1 commit intomainfrom
04-09-fix_ast_type_x_typeof_import_should_be_tstypequery_tsimporttype_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Apr 8, 2025

fixes #10313

@Boshen Boshen requested a review from overlookmotel as a code owner April 8, 2025 16:13
@github-actions github-actions bot added A-parser Area - Parser A-ast Area - AST A-codegen Area - Code Generation labels Apr 8, 2025
Copy link
Member Author

Boshen commented Apr 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Apr 8, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 8, 2025

Merge activity

  • Apr 8, 12:14 PM EDT: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Apr 9, 6:12 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 9, 6:18 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Apr 9, 6:30 AM EDT: Merged by the Graphite merge queue.

@Boshen Boshen changed the title fix(ast): type x = typeof import('') should be TSTypeQuery(TSImportType) fix(parse): type x = typeof import('') -> TSTypeQuery(TSImportType) Apr 8, 2025
@Boshen Boshen force-pushed the 04-09-fix_ast_type_x_typeof_import_should_be_tstypequery_tsimporttype_ branch from 7ef92d2 to 11a2a08 Compare April 9, 2025 10:10
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 9, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 9, 2025

CodSpeed Instrumentation Performance Report

Merging #10317 will degrade performances by 3.69%

Comparing 04-09-fix_ast_type_x_typeof_import_should_be_tstypequery_tsimporttype_ (5850a0d) with main (267922b)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.6 ms 7.9 ms -3.69%
formatter[typescript.js] 7.4 ms 7.2 ms +3.3%

@graphite-app graphite-app bot force-pushed the 04-09-fix_ast_type_x_typeof_import_should_be_tstypequery_tsimporttype_ branch from 11a2a08 to 5850a0d Compare April 9, 2025 10:24
@graphite-app graphite-app bot merged commit 5850a0d into main Apr 9, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 04-09-fix_ast_type_x_typeof_import_should_be_tstypequery_tsimporttype_ branch April 9, 2025 10:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-codegen Area - Code Generation A-parser Area - Parser C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[parser] TSTypeQuery is missing on typeof import(x)

1 participant